2026-01-18 02:52:30 +01:00
|
|
|
using Books.Api.Domain.Companies.Events;
|
|
|
|
|
using EventFlow.Aggregates;
|
|
|
|
|
|
|
|
|
|
namespace Books.Api.Domain.Companies;
|
|
|
|
|
|
Audit v4: VAT calc, SAF-T compliance, security hardening, frontend quality
Backend (17 files):
- VAT: REP 25% deductibility (§42), EU reverse charge double-entry (IEUV/IEUY/IVY),
IVY rate 0%→25%, VatReport Box C/D populated, Basis1 from real revenue
- SAF-T: correct OECD namespace, closing balance net calc, zero-amount fallback,
credit note auto-numbering (§52)
- Security: BankingController CSRF state token + company auth check,
attachment canonical path traversal check, discount 0-100% validation,
deactivated product/customer update guard
- Quality: redact bank API logs, remove dead code (VatCalcService,
PaymentMatchingService), CompanyAggregate IEmit interfaces, fix URL encoding
Frontend (15 files):
- Fix double "kr." in AmountText and Dashboard Statistic components
- Fix UserSettings Switch defaultChecked desync with Form state
- Remove dual useCompany/useCompanyStore pattern (Dashboard, Moms, Bank)
- Correct SKAT VAT deadline calculation per period type
- Add half-yearly/yearly VAT period options
- Guard console.error with import.meta.env.DEV
- Use shared formatDate in BankConnectionsTab
- Remove dead NONE vatCode check, purge 7 legacy VAT codes from type union
- Migrate S25→U25, K25→I25 across all pages
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-06 01:38:52 +01:00
|
|
|
public class CompanyAggregate(CompanyId id) : AggregateRoot<CompanyAggregate, CompanyId>(id),
|
|
|
|
|
IEmit<CompanyCreatedEvent>,
|
|
|
|
|
IEmit<CompanyUpdatedEvent>,
|
|
|
|
|
IEmit<CompanyBankDetailsUpdatedEvent>
|
2026-01-18 02:52:30 +01:00
|
|
|
{
|
|
|
|
|
private bool _isCreated;
|
|
|
|
|
|
|
|
|
|
public void Apply(CompanyCreatedEvent e) => _isCreated = true;
|
|
|
|
|
|
|
|
|
|
public void Apply(CompanyUpdatedEvent e) { }
|
|
|
|
|
|
Audit v4: VAT calc, SAF-T compliance, security hardening, frontend quality
Backend (17 files):
- VAT: REP 25% deductibility (§42), EU reverse charge double-entry (IEUV/IEUY/IVY),
IVY rate 0%→25%, VatReport Box C/D populated, Basis1 from real revenue
- SAF-T: correct OECD namespace, closing balance net calc, zero-amount fallback,
credit note auto-numbering (§52)
- Security: BankingController CSRF state token + company auth check,
attachment canonical path traversal check, discount 0-100% validation,
deactivated product/customer update guard
- Quality: redact bank API logs, remove dead code (VatCalcService,
PaymentMatchingService), CompanyAggregate IEmit interfaces, fix URL encoding
Frontend (15 files):
- Fix double "kr." in AmountText and Dashboard Statistic components
- Fix UserSettings Switch defaultChecked desync with Form state
- Remove dual useCompany/useCompanyStore pattern (Dashboard, Moms, Bank)
- Correct SKAT VAT deadline calculation per period type
- Add half-yearly/yearly VAT period options
- Guard console.error with import.meta.env.DEV
- Use shared formatDate in BankConnectionsTab
- Remove dead NONE vatCode check, purge 7 legacy VAT codes from type union
- Migrate S25→U25, K25→I25 across all pages
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-06 01:38:52 +01:00
|
|
|
public void Apply(CompanyBankDetailsUpdatedEvent e) { }
|
|
|
|
|
|
2026-01-18 02:52:30 +01:00
|
|
|
public void Create(
|
|
|
|
|
string name,
|
|
|
|
|
string? cvr,
|
|
|
|
|
string? address,
|
|
|
|
|
string? postalCode,
|
|
|
|
|
string? city,
|
|
|
|
|
string country,
|
|
|
|
|
int fiscalYearStartMonth,
|
|
|
|
|
string currency,
|
|
|
|
|
bool vatRegistered,
|
|
|
|
|
string? vatPeriodFrequency)
|
|
|
|
|
{
|
|
|
|
|
if (_isCreated)
|
|
|
|
|
throw new DomainException("Company already exists");
|
|
|
|
|
|
|
|
|
|
if (string.IsNullOrWhiteSpace(name))
|
|
|
|
|
throw new DomainException("Company name is required");
|
|
|
|
|
|
|
|
|
|
if (fiscalYearStartMonth < 1 || fiscalYearStartMonth > 12)
|
|
|
|
|
throw new DomainException("Fiscal year start month must be between 1 and 12");
|
|
|
|
|
|
Audit v2: fix security, data integrity, compliance, bugs, encoding, UX
Backend Security & Data Integrity:
- Block negative debit/credit amounts that bypass balance validation
- Require document date at posting (was optional, bypassing fiscal year checks)
- Fix event sourcing anti-pattern: timestamps now stored in events, not UtcNow in Apply
- Add [Authorize] to BankingController OAuth callback
- Add company access check on attachment downloads
- Validate CVR in CompanyAggregate.Create and CompanyAggregate.Update
- Require company CVR for invoice creation (Momsloven §52)
- Delete leftover WeatherForecastController
- Fix duplicate migration number 007 (renamed to 007b)
- Remove dead code in VatCalculationService (identical if/else branches)
Accounting Compliance:
- Add missing VAT accounts to StandardDanishAccounts (5610, 5611, 5620)
- Populate SAF-T TaxInformation on transaction lines (was always null)
- Add AuditFileCountry and TaxRegistrationNumber to SAF-T header
Critical Frontend Bugs:
- Fix Dashboard <a href> causing full page reloads (now uses React Router Link)
- Wire Kassekladde filters to actual data (account, status, date range)
- Pre-populate form when editing existing Kassekladde drafts
- Add detail drawer for "Vis detaljer" action (was just a toast)
- Toggle advanced filters with "Flere filtre" button
- CloseFiscalYearWizard now actually posts closing entries via mutations
- "Create next year" checkbox now creates the next fiscal year
Danish Character Encoding (~50 fixes):
- Fix ø/æ/å across Momsindberetning, DocumentUploadModal, Bankafstemning,
Kontooversigt, CloseFiscalYearWizard, vatCodes, periodStore, periods,
accounting, types/periods
Dead Buttons & UX:
- Disable Momsindberetning PDF/Export buttons with tooltips
- FiscalYearSelector "Administrer" now navigates to Settings
- Settings bank tab now uses real BankConnectionsTab component
- Bankafstemning save button disabled with development tooltip
- Replace hardcoded account options with real API data (Bankafstemning, Fakturaer)
- Header help button shows info message, notification bell shows popover
Consistency & Quality:
- Remove 7 console.log statements from production code
- Adopt PageHeader on 6 remaining pages (Kreditnotaer, Settings, Admin, etc.)
- Standardize loading states to Skeleton pattern (5 pages)
- Replace deprecated bodyStyle prop on Ant Design Cards
- Standardize date format to DD-MM-YYYY
- Fix sidebar width mismatch in designTokens
- Fix Kontooversigt breadcrumb pointing to non-existent route
Accessibility:
- Add aria-label to sidebar navigation
- Add +/- prefix to AmountText for color-blind users
- Fix CompanySwitcher permanent skeleton when no companies
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-06 00:18:19 +01:00
|
|
|
// Validate CVR number if provided
|
|
|
|
|
if (!string.IsNullOrWhiteSpace(cvr) && !CvrValidator.IsValid(cvr.Trim()))
|
|
|
|
|
throw new DomainException(
|
|
|
|
|
"INVALID_CVR",
|
|
|
|
|
$"CVR number '{cvr}' is not valid. Must be 8 digits with valid checksum.",
|
|
|
|
|
$"CVR-nummer '{cvr}' er ugyldigt. Skal være 8 cifre med gyldig kontrolsum.");
|
|
|
|
|
|
2026-01-18 02:52:30 +01:00
|
|
|
Emit(new CompanyCreatedEvent(
|
|
|
|
|
name.Trim(),
|
|
|
|
|
cvr?.Trim(),
|
|
|
|
|
address?.Trim(),
|
|
|
|
|
postalCode?.Trim(),
|
|
|
|
|
city?.Trim(),
|
|
|
|
|
country,
|
|
|
|
|
fiscalYearStartMonth,
|
|
|
|
|
currency,
|
|
|
|
|
vatRegistered,
|
|
|
|
|
vatPeriodFrequency));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public void Update(
|
|
|
|
|
string name,
|
|
|
|
|
string? cvr,
|
|
|
|
|
string? address,
|
|
|
|
|
string? postalCode,
|
|
|
|
|
string? city,
|
|
|
|
|
string country,
|
|
|
|
|
int fiscalYearStartMonth,
|
|
|
|
|
string currency,
|
|
|
|
|
bool vatRegistered,
|
|
|
|
|
string? vatPeriodFrequency)
|
|
|
|
|
{
|
|
|
|
|
if (!_isCreated)
|
|
|
|
|
throw new DomainException("Company does not exist");
|
|
|
|
|
|
|
|
|
|
if (string.IsNullOrWhiteSpace(name))
|
|
|
|
|
throw new DomainException("Company name is required");
|
|
|
|
|
|
|
|
|
|
if (fiscalYearStartMonth < 1 || fiscalYearStartMonth > 12)
|
|
|
|
|
throw new DomainException("Fiscal year start month must be between 1 and 12");
|
|
|
|
|
|
Audit v2: fix security, data integrity, compliance, bugs, encoding, UX
Backend Security & Data Integrity:
- Block negative debit/credit amounts that bypass balance validation
- Require document date at posting (was optional, bypassing fiscal year checks)
- Fix event sourcing anti-pattern: timestamps now stored in events, not UtcNow in Apply
- Add [Authorize] to BankingController OAuth callback
- Add company access check on attachment downloads
- Validate CVR in CompanyAggregate.Create and CompanyAggregate.Update
- Require company CVR for invoice creation (Momsloven §52)
- Delete leftover WeatherForecastController
- Fix duplicate migration number 007 (renamed to 007b)
- Remove dead code in VatCalculationService (identical if/else branches)
Accounting Compliance:
- Add missing VAT accounts to StandardDanishAccounts (5610, 5611, 5620)
- Populate SAF-T TaxInformation on transaction lines (was always null)
- Add AuditFileCountry and TaxRegistrationNumber to SAF-T header
Critical Frontend Bugs:
- Fix Dashboard <a href> causing full page reloads (now uses React Router Link)
- Wire Kassekladde filters to actual data (account, status, date range)
- Pre-populate form when editing existing Kassekladde drafts
- Add detail drawer for "Vis detaljer" action (was just a toast)
- Toggle advanced filters with "Flere filtre" button
- CloseFiscalYearWizard now actually posts closing entries via mutations
- "Create next year" checkbox now creates the next fiscal year
Danish Character Encoding (~50 fixes):
- Fix ø/æ/å across Momsindberetning, DocumentUploadModal, Bankafstemning,
Kontooversigt, CloseFiscalYearWizard, vatCodes, periodStore, periods,
accounting, types/periods
Dead Buttons & UX:
- Disable Momsindberetning PDF/Export buttons with tooltips
- FiscalYearSelector "Administrer" now navigates to Settings
- Settings bank tab now uses real BankConnectionsTab component
- Bankafstemning save button disabled with development tooltip
- Replace hardcoded account options with real API data (Bankafstemning, Fakturaer)
- Header help button shows info message, notification bell shows popover
Consistency & Quality:
- Remove 7 console.log statements from production code
- Adopt PageHeader on 6 remaining pages (Kreditnotaer, Settings, Admin, etc.)
- Standardize loading states to Skeleton pattern (5 pages)
- Replace deprecated bodyStyle prop on Ant Design Cards
- Standardize date format to DD-MM-YYYY
- Fix sidebar width mismatch in designTokens
- Fix Kontooversigt breadcrumb pointing to non-existent route
Accessibility:
- Add aria-label to sidebar navigation
- Add +/- prefix to AmountText for color-blind users
- Fix CompanySwitcher permanent skeleton when no companies
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-06 00:18:19 +01:00
|
|
|
// Validate CVR number if provided
|
|
|
|
|
if (!string.IsNullOrWhiteSpace(cvr) && !CvrValidator.IsValid(cvr.Trim()))
|
|
|
|
|
throw new DomainException(
|
|
|
|
|
"INVALID_CVR",
|
|
|
|
|
$"CVR number '{cvr}' is not valid. Must be 8 digits with valid checksum.",
|
|
|
|
|
$"CVR-nummer '{cvr}' er ugyldigt. Skal være 8 cifre med gyldig kontrolsum.");
|
|
|
|
|
|
2026-01-18 02:52:30 +01:00
|
|
|
Emit(new CompanyUpdatedEvent(
|
|
|
|
|
name.Trim(),
|
|
|
|
|
cvr?.Trim(),
|
|
|
|
|
address?.Trim(),
|
|
|
|
|
postalCode?.Trim(),
|
|
|
|
|
city?.Trim(),
|
|
|
|
|
country,
|
|
|
|
|
fiscalYearStartMonth,
|
|
|
|
|
currency,
|
|
|
|
|
vatRegistered,
|
|
|
|
|
vatPeriodFrequency));
|
|
|
|
|
}
|
|
|
|
|
}
|