Backend Security & Data Integrity: - Block negative debit/credit amounts that bypass balance validation - Require document date at posting (was optional, bypassing fiscal year checks) - Fix event sourcing anti-pattern: timestamps now stored in events, not UtcNow in Apply - Add [Authorize] to BankingController OAuth callback - Add company access check on attachment downloads - Validate CVR in CompanyAggregate.Create and CompanyAggregate.Update - Require company CVR for invoice creation (Momsloven §52) - Delete leftover WeatherForecastController - Fix duplicate migration number 007 (renamed to 007b) - Remove dead code in VatCalculationService (identical if/else branches) Accounting Compliance: - Add missing VAT accounts to StandardDanishAccounts (5610, 5611, 5620) - Populate SAF-T TaxInformation on transaction lines (was always null) - Add AuditFileCountry and TaxRegistrationNumber to SAF-T header Critical Frontend Bugs: - Fix Dashboard <a href> causing full page reloads (now uses React Router Link) - Wire Kassekladde filters to actual data (account, status, date range) - Pre-populate form when editing existing Kassekladde drafts - Add detail drawer for "Vis detaljer" action (was just a toast) - Toggle advanced filters with "Flere filtre" button - CloseFiscalYearWizard now actually posts closing entries via mutations - "Create next year" checkbox now creates the next fiscal year Danish Character Encoding (~50 fixes): - Fix ø/æ/å across Momsindberetning, DocumentUploadModal, Bankafstemning, Kontooversigt, CloseFiscalYearWizard, vatCodes, periodStore, periods, accounting, types/periods Dead Buttons & UX: - Disable Momsindberetning PDF/Export buttons with tooltips - FiscalYearSelector "Administrer" now navigates to Settings - Settings bank tab now uses real BankConnectionsTab component - Bankafstemning save button disabled with development tooltip - Replace hardcoded account options with real API data (Bankafstemning, Fakturaer) - Header help button shows info message, notification bell shows popover Consistency & Quality: - Remove 7 console.log statements from production code - Adopt PageHeader on 6 remaining pages (Kreditnotaer, Settings, Admin, etc.) - Standardize loading states to Skeleton pattern (5 pages) - Replace deprecated bodyStyle prop on Ant Design Cards - Standardize date format to DD-MM-YYYY - Fix sidebar width mismatch in designTokens - Fix Kontooversigt breadcrumb pointing to non-existent route Accessibility: - Add aria-label to sidebar navigation - Add +/- prefix to AmountText for color-blind users - Fix CompanySwitcher permanent skeleton when no companies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
247 lines
7.4 KiB
C#
247 lines
7.4 KiB
C#
using Books.Api.Domain;
|
|
using Books.Api.Domain.Invoices;
|
|
using Books.Api.EventFlow.Repositories;
|
|
using Books.Api.Invoicing.Services;
|
|
using EventFlow.Commands;
|
|
|
|
namespace Books.Api.Commands.Invoices;
|
|
|
|
/// <summary>
|
|
/// Command handler for creating invoices.
|
|
/// Auto-assigns a sequential invoice number if one is not provided.
|
|
/// Validates the company has a CVR number (required for invoicing).
|
|
/// </summary>
|
|
public class CreateInvoiceCommandHandler(
|
|
IInvoiceNumberService invoiceNumberService,
|
|
ICompanyRepository companyRepository)
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, CreateInvoiceCommand>
|
|
{
|
|
public override async Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
CreateInvoiceCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
// Validate company has a CVR number (required for invoicing per Danish law)
|
|
var company = await companyRepository.GetByIdAsync(command.CompanyId, cancellationToken);
|
|
if (company == null)
|
|
{
|
|
throw new DomainException(
|
|
"COMPANY_NOT_FOUND",
|
|
$"Company '{command.CompanyId}' not found",
|
|
$"Virksomheden '{command.CompanyId}' blev ikke fundet");
|
|
}
|
|
|
|
if (string.IsNullOrWhiteSpace(company.Cvr))
|
|
{
|
|
throw new DomainException(
|
|
"CVR_REQUIRED_FOR_INVOICE",
|
|
"Company must have a CVR number to create invoices. Please update company settings.",
|
|
"Virksomheden skal have et CVR-nummer for at oprette fakturaer. Opdater venligst virksomhedsindstillinger.");
|
|
}
|
|
|
|
// Auto-assign invoice number if not provided
|
|
var invoiceNumber = command.InvoiceNumber;
|
|
if (string.IsNullOrWhiteSpace(invoiceNumber))
|
|
{
|
|
invoiceNumber = await invoiceNumberService.GetNextInvoiceNumberAsync(
|
|
command.CompanyId,
|
|
command.InvoiceDate.Year,
|
|
cancellationToken);
|
|
}
|
|
|
|
aggregate.Create(
|
|
command.CompanyId,
|
|
command.FiscalYearId,
|
|
command.CustomerId,
|
|
command.CustomerName,
|
|
command.CustomerNumber,
|
|
invoiceNumber,
|
|
command.InvoiceDate,
|
|
command.DueDate,
|
|
command.PaymentTermsDays,
|
|
command.Currency,
|
|
command.VatCode,
|
|
command.Notes,
|
|
command.Reference,
|
|
command.CreatedBy);
|
|
}
|
|
}
|
|
|
|
public class AddInvoiceLineCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, AddInvoiceLineCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
AddInvoiceLineCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.AddLine(
|
|
command.Description,
|
|
command.Quantity,
|
|
command.UnitPrice,
|
|
command.VatCode,
|
|
command.AccountId,
|
|
command.Unit,
|
|
command.DiscountPercent);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class UpdateInvoiceLineCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, UpdateInvoiceLineCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
UpdateInvoiceLineCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.UpdateLine(
|
|
command.LineNumber,
|
|
command.Description,
|
|
command.Quantity,
|
|
command.UnitPrice,
|
|
command.VatCode,
|
|
command.AccountId,
|
|
command.Unit,
|
|
command.DiscountPercent);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class RemoveInvoiceLineCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, RemoveInvoiceLineCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
RemoveInvoiceLineCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.RemoveLine(command.LineNumber);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class MarkInvoiceSentCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, MarkInvoiceSentCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
MarkInvoiceSentCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.Send(
|
|
command.LedgerTransactionId,
|
|
command.SentBy);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class ReceiveInvoicePaymentCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, ReceiveInvoicePaymentCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
ReceiveInvoicePaymentCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.ReceivePayment(
|
|
command.Amount,
|
|
command.BankTransactionId,
|
|
command.LedgerTransactionId,
|
|
command.PaymentReference,
|
|
command.PaymentDate,
|
|
command.RecordedBy);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class VoidInvoiceCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, VoidInvoiceCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
VoidInvoiceCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.Void(
|
|
command.Reason,
|
|
command.ReversalLedgerTransactionId,
|
|
command.VoidedBy);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
// =====================================================
|
|
// CREDIT NOTE COMMAND HANDLERS
|
|
// =====================================================
|
|
|
|
public class CreateCreditNoteCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, CreateCreditNoteCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
CreateCreditNoteCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.CreateCreditNote(
|
|
command.CompanyId,
|
|
command.FiscalYearId,
|
|
command.CustomerId,
|
|
command.CustomerName,
|
|
command.CustomerNumber,
|
|
command.CreditNoteNumber,
|
|
command.CreditNoteDate,
|
|
command.Currency,
|
|
command.VatCode,
|
|
command.Notes,
|
|
command.Reference,
|
|
command.CreatedBy,
|
|
command.OriginalInvoiceId,
|
|
command.OriginalInvoiceNumber,
|
|
command.CreditReason);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class IssueCreditNoteCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, IssueCreditNoteCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
IssueCreditNoteCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.Issue(
|
|
command.LedgerTransactionId,
|
|
command.IssuedBy);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class ApplyCreditNoteCommandHandler
|
|
: CommandHandler<InvoiceAggregate, InvoiceId, ApplyCreditNoteCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
InvoiceAggregate aggregate,
|
|
ApplyCreditNoteCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.ApplyCredit(
|
|
command.TargetInvoiceId,
|
|
command.TargetInvoiceNumber,
|
|
command.Amount,
|
|
command.AppliedDate,
|
|
command.AppliedBy,
|
|
command.LedgerTransactionId);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|