Backend Security & Data Integrity: - Block negative debit/credit amounts that bypass balance validation - Require document date at posting (was optional, bypassing fiscal year checks) - Fix event sourcing anti-pattern: timestamps now stored in events, not UtcNow in Apply - Add [Authorize] to BankingController OAuth callback - Add company access check on attachment downloads - Validate CVR in CompanyAggregate.Create and CompanyAggregate.Update - Require company CVR for invoice creation (Momsloven §52) - Delete leftover WeatherForecastController - Fix duplicate migration number 007 (renamed to 007b) - Remove dead code in VatCalculationService (identical if/else branches) Accounting Compliance: - Add missing VAT accounts to StandardDanishAccounts (5610, 5611, 5620) - Populate SAF-T TaxInformation on transaction lines (was always null) - Add AuditFileCountry and TaxRegistrationNumber to SAF-T header Critical Frontend Bugs: - Fix Dashboard <a href> causing full page reloads (now uses React Router Link) - Wire Kassekladde filters to actual data (account, status, date range) - Pre-populate form when editing existing Kassekladde drafts - Add detail drawer for "Vis detaljer" action (was just a toast) - Toggle advanced filters with "Flere filtre" button - CloseFiscalYearWizard now actually posts closing entries via mutations - "Create next year" checkbox now creates the next fiscal year Danish Character Encoding (~50 fixes): - Fix ø/æ/å across Momsindberetning, DocumentUploadModal, Bankafstemning, Kontooversigt, CloseFiscalYearWizard, vatCodes, periodStore, periods, accounting, types/periods Dead Buttons & UX: - Disable Momsindberetning PDF/Export buttons with tooltips - FiscalYearSelector "Administrer" now navigates to Settings - Settings bank tab now uses real BankConnectionsTab component - Bankafstemning save button disabled with development tooltip - Replace hardcoded account options with real API data (Bankafstemning, Fakturaer) - Header help button shows info message, notification bell shows popover Consistency & Quality: - Remove 7 console.log statements from production code - Adopt PageHeader on 6 remaining pages (Kreditnotaer, Settings, Admin, etc.) - Standardize loading states to Skeleton pattern (5 pages) - Replace deprecated bodyStyle prop on Ant Design Cards - Standardize date format to DD-MM-YYYY - Fix sidebar width mismatch in designTokens - Fix Kontooversigt breadcrumb pointing to non-existent route Accessibility: - Add aria-label to sidebar navigation - Add +/- prefix to AmountText for color-blind users - Fix CompanySwitcher permanent skeleton when no companies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
139 lines
5 KiB
C#
139 lines
5 KiB
C#
using Books.Api.Domain;
|
|
using Books.Api.Domain.JournalEntryDrafts;
|
|
using Books.Api.EventFlow.Repositories;
|
|
using EventFlow.Commands;
|
|
|
|
namespace Books.Api.Commands.JournalEntryDrafts;
|
|
|
|
public class CreateJournalEntryDraftCommandHandler
|
|
: CommandHandler<JournalEntryDraftAggregate, JournalEntryDraftId, CreateJournalEntryDraftCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
JournalEntryDraftAggregate aggregate,
|
|
CreateJournalEntryDraftCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.Create(
|
|
command.CompanyId,
|
|
command.Name,
|
|
command.CreatedBy,
|
|
command.VoucherNumber,
|
|
command.ExtractionData);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
public class UpdateJournalEntryDraftCommandHandler
|
|
: CommandHandler<JournalEntryDraftAggregate, JournalEntryDraftId, UpdateJournalEntryDraftCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
JournalEntryDraftAggregate aggregate,
|
|
UpdateJournalEntryDraftCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.Update(
|
|
command.Name,
|
|
command.DocumentDate,
|
|
command.Description,
|
|
command.FiscalYearId,
|
|
command.Lines,
|
|
command.AttachmentIds);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Command handler for posting a journal entry draft.
|
|
/// Validates fiscal year status and date range before allowing the post.
|
|
/// </summary>
|
|
public class MarkJournalEntryDraftPostedCommandHandler(
|
|
IJournalEntryDraftRepository draftRepository,
|
|
IFiscalYearRepository fiscalYearRepository)
|
|
: CommandHandler<JournalEntryDraftAggregate, JournalEntryDraftId, MarkJournalEntryDraftPostedCommand>
|
|
{
|
|
public override async Task ExecuteAsync(
|
|
JournalEntryDraftAggregate aggregate,
|
|
MarkJournalEntryDraftPostedCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
// Load the draft read model to get fiscal year and document date
|
|
var draft = await draftRepository.GetByIdAsync(
|
|
aggregate.Id.Value, cancellationToken);
|
|
|
|
var fiscalYearId = draft?.FiscalYearId ?? aggregate.FiscalYearId;
|
|
|
|
// Validate fiscal year is set
|
|
if (string.IsNullOrWhiteSpace(fiscalYearId))
|
|
{
|
|
throw new DomainException(
|
|
"FISCAL_YEAR_REQUIRED",
|
|
"Fiscal year is required for posting a journal entry",
|
|
"Regnskabsår er påkrævet for bogføring af en postering");
|
|
}
|
|
|
|
// Fetch and validate fiscal year
|
|
var fiscalYear = await fiscalYearRepository.GetByIdAsync(
|
|
fiscalYearId, cancellationToken);
|
|
|
|
if (fiscalYear == null)
|
|
{
|
|
throw new DomainException(
|
|
"FISCAL_YEAR_NOT_FOUND",
|
|
$"Fiscal year '{fiscalYearId}' not found",
|
|
$"Regnskabsår '{fiscalYearId}' blev ikke fundet");
|
|
}
|
|
|
|
// Validate fiscal year is open (not Closed or Locked)
|
|
if (fiscalYear.Status != "Open")
|
|
{
|
|
throw new DomainException(
|
|
"FISCAL_YEAR_NOT_OPEN",
|
|
$"Fiscal year is {fiscalYear.Status}. Only open fiscal years allow posting.",
|
|
$"Regnskabsåret er {fiscalYear.Status}. Kun åbne regnskabsår tillader bogføring.");
|
|
}
|
|
|
|
// Validate document date is set (required for posting per Bogføringsloven)
|
|
if (draft?.DocumentDate == null)
|
|
{
|
|
throw new DomainException(
|
|
"DOCUMENT_DATE_REQUIRED",
|
|
"Document date (bilagsdato) is required for posting a journal entry",
|
|
"Bilagsdato er påkrævet for bogføring af en postering");
|
|
}
|
|
|
|
// Validate document date falls within fiscal year range
|
|
{
|
|
var documentDate = DateOnly.FromDateTime(draft.DocumentDate.Value);
|
|
var fyStart = DateOnly.FromDateTime(fiscalYear.StartDate);
|
|
var fyEnd = DateOnly.FromDateTime(fiscalYear.EndDate);
|
|
|
|
if (documentDate < fyStart || documentDate > fyEnd)
|
|
{
|
|
throw new DomainException(
|
|
"DOCUMENT_DATE_OUTSIDE_FISCAL_YEAR",
|
|
$"Document date {documentDate:yyyy-MM-dd} falls outside the fiscal year ({fyStart:yyyy-MM-dd} to {fyEnd:yyyy-MM-dd})",
|
|
$"Bilagsdato {documentDate:yyyy-MM-dd} ligger uden for regnskabsåret ({fyStart:yyyy-MM-dd} til {fyEnd:yyyy-MM-dd})");
|
|
}
|
|
}
|
|
|
|
aggregate.MarkPosted(
|
|
command.TransactionId,
|
|
command.PostedBy);
|
|
}
|
|
}
|
|
|
|
public class DiscardJournalEntryDraftCommandHandler
|
|
: CommandHandler<JournalEntryDraftAggregate, JournalEntryDraftId, DiscardJournalEntryDraftCommand>
|
|
{
|
|
public override Task ExecuteAsync(
|
|
JournalEntryDraftAggregate aggregate,
|
|
DiscardJournalEntryDraftCommand command,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
aggregate.Discard(command.DiscardedBy);
|
|
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|