Nicolaj Hartmann
709d0a4739
Backend Security & Data Integrity: - Block negative debit/credit amounts that bypass balance validation - Require document date at posting (was optional, bypassing fiscal year checks) - Fix event sourcing anti-pattern: timestamps now stored in events, not UtcNow in Apply - Add [Authorize] to BankingController OAuth callback - Add company access check on attachment downloads - Validate CVR in CompanyAggregate.Create and CompanyAggregate.Update - Require company CVR for invoice creation (Momsloven §52) - Delete leftover WeatherForecastController - Fix duplicate migration number 007 (renamed to 007b) - Remove dead code in VatCalculationService (identical if/else branches) Accounting Compliance: - Add missing VAT accounts to StandardDanishAccounts (5610, 5611, 5620) - Populate SAF-T TaxInformation on transaction lines (was always null) - Add AuditFileCountry and TaxRegistrationNumber to SAF-T header Critical Frontend Bugs: - Fix Dashboard <a href> causing full page reloads (now uses React Router Link) - Wire Kassekladde filters to actual data (account, status, date range) - Pre-populate form when editing existing Kassekladde drafts - Add detail drawer for "Vis detaljer" action (was just a toast) - Toggle advanced filters with "Flere filtre" button - CloseFiscalYearWizard now actually posts closing entries via mutations - "Create next year" checkbox now creates the next fiscal year Danish Character Encoding (~50 fixes): - Fix ø/æ/å across Momsindberetning, DocumentUploadModal, Bankafstemning, Kontooversigt, CloseFiscalYearWizard, vatCodes, periodStore, periods, accounting, types/periods Dead Buttons & UX: - Disable Momsindberetning PDF/Export buttons with tooltips - FiscalYearSelector "Administrer" now navigates to Settings - Settings bank tab now uses real BankConnectionsTab component - Bankafstemning save button disabled with development tooltip - Replace hardcoded account options with real API data (Bankafstemning, Fakturaer) - Header help button shows info message, notification bell shows popover Consistency & Quality: - Remove 7 console.log statements from production code - Adopt PageHeader on 6 remaining pages (Kreditnotaer, Settings, Admin, etc.) - Standardize loading states to Skeleton pattern (5 pages) - Replace deprecated bodyStyle prop on Ant Design Cards - Standardize date format to DD-MM-YYYY - Fix sidebar width mismatch in designTokens - Fix Kontooversigt breadcrumb pointing to non-existent route Accessibility: - Add aria-label to sidebar navigation - Add +/- prefix to AmountText for color-blind users - Fix CompanySwitcher permanent skeleton when no companies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
45 lines
2.4 KiB
SQL
45 lines
2.4 KiB
SQL
-- Migration: 007_JournalEntryDraftCompliance
|
|
-- Description: Add Danish accounting law compliance fields to journal entry drafts
|
|
-- - VoucherNumber (Bilagsnummer) - required by Bogføringsloven § 7, Stk. 4
|
|
-- - AttachmentIds - for document references required by Bogføringsloven § 6
|
|
-- - DocumentDate (Bilagsdato) - renamed from generic "date" for clarity
|
|
-- - Voucher sequence table for auto-generation of bilagsnumre
|
|
|
|
-- Add voucher_number column to existing table
|
|
ALTER TABLE journal_entry_draft_read_models
|
|
ADD COLUMN IF NOT EXISTS voucher_number TEXT NOT NULL DEFAULT '';
|
|
|
|
-- Add attachment_ids column (JSON array of references)
|
|
ALTER TABLE journal_entry_draft_read_models
|
|
ADD COLUMN IF NOT EXISTS attachment_ids TEXT NOT NULL DEFAULT '[]';
|
|
|
|
-- Rename date column to document_date (Bilagsdato) for semantic clarity
|
|
-- document_date = the date on the source document (e.g., invoice date)
|
|
-- This is different from posting_date which is when it's booked in the ledger
|
|
ALTER TABLE journal_entry_draft_read_models
|
|
RENAME COLUMN date TO document_date;
|
|
|
|
-- Create voucher number sequence table per company/fiscal year
|
|
-- This ensures unique, sequential bilagsnumre as required by law
|
|
CREATE TABLE IF NOT EXISTS voucher_number_sequences (
|
|
company_id TEXT NOT NULL,
|
|
fiscal_year_id TEXT NOT NULL,
|
|
last_number INT NOT NULL DEFAULT 0,
|
|
prefix TEXT NOT NULL DEFAULT '',
|
|
created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
|
|
updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
|
|
PRIMARY KEY (company_id, fiscal_year_id)
|
|
);
|
|
|
|
-- Index for efficient lookup
|
|
CREATE INDEX IF NOT EXISTS idx_voucher_sequence_company
|
|
ON voucher_number_sequences(company_id);
|
|
|
|
-- Index for efficient queries by voucher number
|
|
CREATE INDEX IF NOT EXISTS idx_journal_entry_draft_voucher
|
|
ON journal_entry_draft_read_models(company_id, voucher_number);
|
|
|
|
COMMENT ON TABLE voucher_number_sequences IS 'Sequence generator for bilagsnumre (voucher numbers) per company and fiscal year';
|
|
COMMENT ON COLUMN voucher_number_sequences.prefix IS 'Optional prefix for voucher numbers, e.g. "2025-" for year-based numbering';
|
|
COMMENT ON COLUMN journal_entry_draft_read_models.voucher_number IS 'Bilagsnummer - unique document number required by Bogføringsloven § 7, Stk. 4';
|
|
COMMENT ON COLUMN journal_entry_draft_read_models.attachment_ids IS 'JSON array of attachment IDs for document references required by Bogføringsloven § 6';
|