Nicolaj Hartmann
709d0a4739
Backend Security & Data Integrity: - Block negative debit/credit amounts that bypass balance validation - Require document date at posting (was optional, bypassing fiscal year checks) - Fix event sourcing anti-pattern: timestamps now stored in events, not UtcNow in Apply - Add [Authorize] to BankingController OAuth callback - Add company access check on attachment downloads - Validate CVR in CompanyAggregate.Create and CompanyAggregate.Update - Require company CVR for invoice creation (Momsloven §52) - Delete leftover WeatherForecastController - Fix duplicate migration number 007 (renamed to 007b) - Remove dead code in VatCalculationService (identical if/else branches) Accounting Compliance: - Add missing VAT accounts to StandardDanishAccounts (5610, 5611, 5620) - Populate SAF-T TaxInformation on transaction lines (was always null) - Add AuditFileCountry and TaxRegistrationNumber to SAF-T header Critical Frontend Bugs: - Fix Dashboard <a href> causing full page reloads (now uses React Router Link) - Wire Kassekladde filters to actual data (account, status, date range) - Pre-populate form when editing existing Kassekladde drafts - Add detail drawer for "Vis detaljer" action (was just a toast) - Toggle advanced filters with "Flere filtre" button - CloseFiscalYearWizard now actually posts closing entries via mutations - "Create next year" checkbox now creates the next fiscal year Danish Character Encoding (~50 fixes): - Fix ø/æ/å across Momsindberetning, DocumentUploadModal, Bankafstemning, Kontooversigt, CloseFiscalYearWizard, vatCodes, periodStore, periods, accounting, types/periods Dead Buttons & UX: - Disable Momsindberetning PDF/Export buttons with tooltips - FiscalYearSelector "Administrer" now navigates to Settings - Settings bank tab now uses real BankConnectionsTab component - Bankafstemning save button disabled with development tooltip - Replace hardcoded account options with real API data (Bankafstemning, Fakturaer) - Header help button shows info message, notification bell shows popover Consistency & Quality: - Remove 7 console.log statements from production code - Adopt PageHeader on 6 remaining pages (Kreditnotaer, Settings, Admin, etc.) - Standardize loading states to Skeleton pattern (5 pages) - Replace deprecated bodyStyle prop on Ant Design Cards - Standardize date format to DD-MM-YYYY - Fix sidebar width mismatch in designTokens - Fix Kontooversigt breadcrumb pointing to non-existent route Accessibility: - Add aria-label to sidebar navigation - Add +/- prefix to AmountText for color-blind users - Fix CompanySwitcher permanent skeleton when no companies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
95 lines
3 KiB
C#
95 lines
3 KiB
C#
using Books.Api.Domain.Companies.Events;
|
|
using EventFlow.Aggregates;
|
|
|
|
namespace Books.Api.Domain.Companies;
|
|
|
|
public class CompanyAggregate(CompanyId id) : AggregateRoot<CompanyAggregate, CompanyId>(id)
|
|
{
|
|
private bool _isCreated;
|
|
|
|
public void Apply(CompanyCreatedEvent e) => _isCreated = true;
|
|
|
|
public void Apply(CompanyUpdatedEvent e) { }
|
|
|
|
public void Create(
|
|
string name,
|
|
string? cvr,
|
|
string? address,
|
|
string? postalCode,
|
|
string? city,
|
|
string country,
|
|
int fiscalYearStartMonth,
|
|
string currency,
|
|
bool vatRegistered,
|
|
string? vatPeriodFrequency)
|
|
{
|
|
if (_isCreated)
|
|
throw new DomainException("Company already exists");
|
|
|
|
if (string.IsNullOrWhiteSpace(name))
|
|
throw new DomainException("Company name is required");
|
|
|
|
if (fiscalYearStartMonth < 1 || fiscalYearStartMonth > 12)
|
|
throw new DomainException("Fiscal year start month must be between 1 and 12");
|
|
|
|
// Validate CVR number if provided
|
|
if (!string.IsNullOrWhiteSpace(cvr) && !CvrValidator.IsValid(cvr.Trim()))
|
|
throw new DomainException(
|
|
"INVALID_CVR",
|
|
$"CVR number '{cvr}' is not valid. Must be 8 digits with valid checksum.",
|
|
$"CVR-nummer '{cvr}' er ugyldigt. Skal være 8 cifre med gyldig kontrolsum.");
|
|
|
|
Emit(new CompanyCreatedEvent(
|
|
name.Trim(),
|
|
cvr?.Trim(),
|
|
address?.Trim(),
|
|
postalCode?.Trim(),
|
|
city?.Trim(),
|
|
country,
|
|
fiscalYearStartMonth,
|
|
currency,
|
|
vatRegistered,
|
|
vatPeriodFrequency));
|
|
}
|
|
|
|
public void Update(
|
|
string name,
|
|
string? cvr,
|
|
string? address,
|
|
string? postalCode,
|
|
string? city,
|
|
string country,
|
|
int fiscalYearStartMonth,
|
|
string currency,
|
|
bool vatRegistered,
|
|
string? vatPeriodFrequency)
|
|
{
|
|
if (!_isCreated)
|
|
throw new DomainException("Company does not exist");
|
|
|
|
if (string.IsNullOrWhiteSpace(name))
|
|
throw new DomainException("Company name is required");
|
|
|
|
if (fiscalYearStartMonth < 1 || fiscalYearStartMonth > 12)
|
|
throw new DomainException("Fiscal year start month must be between 1 and 12");
|
|
|
|
// Validate CVR number if provided
|
|
if (!string.IsNullOrWhiteSpace(cvr) && !CvrValidator.IsValid(cvr.Trim()))
|
|
throw new DomainException(
|
|
"INVALID_CVR",
|
|
$"CVR number '{cvr}' is not valid. Must be 8 digits with valid checksum.",
|
|
$"CVR-nummer '{cvr}' er ugyldigt. Skal være 8 cifre med gyldig kontrolsum.");
|
|
|
|
Emit(new CompanyUpdatedEvent(
|
|
name.Trim(),
|
|
cvr?.Trim(),
|
|
address?.Trim(),
|
|
postalCode?.Trim(),
|
|
city?.Trim(),
|
|
country,
|
|
fiscalYearStartMonth,
|
|
currency,
|
|
vatRegistered,
|
|
vatPeriodFrequency));
|
|
}
|
|
}
|